Skip to content

January a11y Bug Fixes#2410

Merged
cRui861 merged 15 commits intomasterfrom
feature/a11y-nov-21
Jan 28, 2022
Merged

January a11y Bug Fixes#2410
cRui861 merged 15 commits intomasterfrom
feature/a11y-nov-21

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Jan 25, 2022

January accessibility bug fixes include several improvements on luminosity contrast ratios for buttons and forms (including improving visual focus elements and contrasts between background and text colors in multiple elements) and table ordering for tabbing through table columns and rows.

@gingi gingi force-pushed the feature/a11y-nov-21 branch from 5702bae to 1bd755f Compare January 27, 2022 20:59
@gingi gingi added this to the 2.12.0 milestone Jan 27, 2022
@gingi gingi force-pushed the feature/a11y-nov-21 branch 2 times, most recently from d0416c6 to 0b836f5 Compare January 27, 2022 22:12
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #2410 (61d68a5) into master (43b1651) will increase coverage by 0.00%.
The diff coverage is 81.25%.

❗ Current head 61d68a5 differs from pull request most recent head 33f29fa. Consider uploading reports for the commit 33f29fa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2410   +/-   ##
=======================================
  Coverage   64.97%   64.98%           
=======================================
  Files         913      914    +1     
  Lines       26322    26345   +23     
  Branches     5179     5179           
=======================================
+ Hits        17104    17120   +16     
- Misses       9218     9225    +7     
Impacted Files Coverage Δ
src/@batch-flask/ui/batchui.module.ts 100.00% <ø> (ø)
src/@batch-flask/ui/form/form.module.ts 100.00% <ø> (ø)
...tch-flask/ui/property-list/property-list.module.ts 100.00% <ø> (ø)
...erty-list/text-property/text-property.component.ts 100.00% <ø> (ø)
src/@batch-flask/ui/copyable/copyable.directive.ts 84.84% <25.00%> (-8.26%) ⬇️
...batch-flask/ui/abstract-list/abstract-list-base.ts 78.96% <81.25%> (+0.15%) ⬆️
src/@batch-flask/ui/copyable/copyable.module.ts 100.00% <100.00%> (ø)
src/@batch-flask/ui/table/table-column-manager.ts 84.37% <100.00%> (+1.32%) ⬆️
...-head/table-head-cell/table-head-cell.component.ts 96.55% <100.00%> (-1.67%) ⬇️
src/@batch-flask/ui/table/table.component.ts 58.82% <100.00%> (+1.24%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b1651...33f29fa. Read the comment docs.

@gingi gingi force-pushed the feature/a11y-nov-21 branch from 0b836f5 to 43966cc Compare January 27, 2022 22:42
gingi
gingi previously approved these changes Jan 28, 2022
dpwatrous
dpwatrous previously approved these changes Jan 28, 2022
gingi and others added 7 commits January 28, 2022 14:44
List focus is handled by component only after table body receives focus, allowing table columns to be focused in the correct tab order.
Table cell header for updating storage account information should have a color contrast of 3:1
* Outline for keyboard-focused selected rows
* Remove empty column headers from tab order
Fixes AB#489, AB#580
@cRui861 cRui861 enabled auto-merge January 28, 2022 22:47
@cRui861 cRui861 merged commit cd4016b into master Jan 28, 2022
@cRui861 cRui861 deleted the feature/a11y-nov-21 branch January 28, 2022 23:09
@cRui861
Copy link
Member Author

cRui861 commented Jan 31, 2022

Fixes #2419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants