Skip to content

Update to call List Supported Virtual Machine and Cloud Service SKUs#2400

Merged
cRui861 merged 5 commits intomasterfrom
rechen/vmskuupdates
Dec 9, 2021
Merged

Update to call List Supported Virtual Machine and Cloud Service SKUs#2400
cRui861 merged 5 commits intomasterfrom
rechen/vmskuupdates

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Nov 30, 2021

Migrate from using local JSON to Batch Management API calls to retrieve virtual machine and cloud service SKU information.

  • Update unit tests to reflect changes.
  • Move virtual machine category list into this repo from Azure/BatchExplorer-data.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #2400 (982115f) into master (6ba497b) will decrease coverage by 0.01%.
The diff coverage is 92.00%.

❗ Current head 982115f differs from pull request most recent head 46c2372. Consider uploading reports for the commit 46c2372 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
- Coverage   65.26%   65.24%   -0.02%     
==========================================
  Files         903      903              
  Lines       26025    26009      -16     
  Branches     5115     5114       -1     
==========================================
- Hits        16984    16969      -15     
+ Misses       9041     9040       -1     
Impacted Files Coverage Δ
src/app/services/compute/vm-size.service.ts 87.23% <91.30%> (+1.29%) ⬆️
...rc/app/services/compute/vmsize_sample_responses.ts 100.00% <100.00%> (ø)
src/app/services/compute.service.ts 11.86% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba497b...46c2372. Read the comment docs.

@cRui861 cRui861 merged commit 7e9ce2e into master Dec 9, 2021
@cRui861 cRui861 deleted the rechen/vmskuupdates branch December 9, 2021 21:53
@cRui861
Copy link
Member Author

cRui861 commented Jan 31, 2022

Fixes #2416

cRui861 added a commit that referenced this pull request Feb 10, 2022
cRui861 added a commit that referenced this pull request Feb 10, 2022
cRui861 added a commit that referenced this pull request Feb 10, 2022
Revert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)"
dpwatrous pushed a commit that referenced this pull request Feb 16, 2022
cRui861 added a commit that referenced this pull request Mar 1, 2022
…2400)

* Switch to using Service VM SKUs API from pulling json information from GitHub

* Fix 'filter' typo

* Update repo to contain vm size category list and fix unit tests
cRui861 added a commit that referenced this pull request Mar 1, 2022
…2400) (#2456)

* Switch to using Service VM SKUs API from pulling json information from GitHub

* Fix 'filter' typo

* Update repo to contain vm size category list and fix unit tests
cRui861 added a commit that referenced this pull request Mar 18, 2022
cRui861 added a commit that referenced this pull request Mar 22, 2022
cRui861 added a commit that referenced this pull request Mar 22, 2022
cRui861 added a commit that referenced this pull request Mar 23, 2022
* Revert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)"

This reverts commit 7e9ce2e.

* Un-revert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)"

This reverts commit bd30b07.
gingi pushed a commit that referenced this pull request Apr 1, 2022
gingi added a commit that referenced this pull request Apr 1, 2022
…rvice SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.
gingi added a commit that referenced this pull request Apr 1, 2022
…vice SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.
gingi pushed a commit that referenced this pull request Apr 1, 2022
gingi added a commit that referenced this pull request Apr 1, 2022
…vice SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.
gingi added a commit that referenced this pull request Jul 1, 2022
…vice SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.
gingi added a commit that referenced this pull request Jul 1, 2022
…vice SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.
cRui861 added a commit that referenced this pull request Jul 7, 2022
* Revert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)"

This reverts commit 7e9ce2e.

* Update patch version for reverting VM SKU API changes

* Update changelog with hotfix information

* Fix task output warning background color
AB#335

* Fix border contrast of code sample package install inputs

Fixes AB#291

* Fix for missing image icons

Only behavior was spammed errors to the console.

* Fixes AB#315: Native tooltips for gallery actions

* Bumps version to 2.14.0

* Fixes silent DatetimePicker error on midnight value

* Bump plist from 3.0.4 to 3.0.5 (#2493)

Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/TooTallNate/node-plist/releases)
- [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md)
- [Commits](https://github.com/TooTallNate/node-plist/commits)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes AB#465: "Unselect All" navigable by keyboard

* Upgrades to Electron 13

Possibly addresses issues with Conditional Access policies that require a minimum Chromium version of 91. (#2446)

* Bump moment from 2.29.1 to 2.29.3 (#2496)

Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.3.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/2.29.3/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.3)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rena <[email protected]>

* Bump minimist from 1.2.5 to 1.2.6 (#2488)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rena <[email protected]>

* Bump karma from 6.3.14 to 6.3.16 (#2467)

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.14 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/karma@v6.3.14...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rena <[email protected]>

* Fixes issue with failed silent auth

Batch Explorer would not start when an exception is thrown during silent auth that isn't an authentication error.

* Updates @azure/msal-node to 1.6.0

Support for proxied environments.

* Bump ejs from 3.1.6 to 3.1.7

Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/mde/ejs/releases)
- [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md)
- [Commits](mde/ejs@v3.1.6...v3.1.7)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix heatmap node display issues (#2497)

* [WIP] Added new gradient colors to heatmap
TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states

* Categories can expand and contract now and are closed by default.
* colors of the categories will stay as subitem color
* [WIP] need to fix running state error (showing up as black instead of green)
* [WIP] need to add dropdown icon next to categories

* Fix selectState logic and add caret expansion and collapse identifier on categories

* Add logic for handling task slots for running state
* Change task slot colors to be more accessible

* Add 100% for heatmap legend and picked colors for heatmap
* clean up

* Fix typo

* Comment explaining state counter for running task usages

* Remove whitespace

* Fix unit tests
* [WIP] fix unit tests for running task overlay

* Fix async issue and fix state counter unit tests

* Add running task slot usage tests and fix percentages

* Add a few more tests for task slot usage overlay

* Restores native menubar on Windows

In-release regression caused by upgrade to Electron 13 (3bd43c7).

* Adding Sanjana as code owner

* Bump async from 2.6.3 to 2.6.4

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump eventsource from 1.0.7 to 1.1.1

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.0.7...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Adds security linting

* Minor lint fixes

* Remove obsolete directives from debug config

* Utility for creating a proxy environment in Azure

* Installs Batch Explorer in a restricted network.

* Upgrades to @azure/msal-node 1.9.0

* Uses proxy settings for authentication.

* Bump node-forge from 1.0.0 to 1.3.0

Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.0.0 to 1.3.0.
- [Release notes](https://github.com/digitalbazaar/forge/releases)
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@v1.0.0...v1.3.0)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fixes cer parsing unit test using updated forge

* Microsoft mandatory file

* Excludes auto-generated SECURITY.md from linting

* Bumps azure-storage from 2.10.4 to 2.10.7

Fixes AB#766, AB#768: Addresses some security vulnerabilities in module dependencies (validator and json-schema).

* Bumps hosted-git-info from 2.8.8 to 2.8.9

* Bumps ansi-html, normalize-url

* Bumps @azure/msal-node from 1.9.0 to 1.10.0

Addresses issue with caching multiple tokens for same user (AzureAD/microsoft-authentication-library-for-js#4486).

* May a11y Bug Fixes (#2520)

* Fix AB#515: Narrator reports wrong Max retry count

* Fix AB#516: Graphs are inaccessible in scan mode

* Fix AB#517: Label is not associated with control

Co-authored-by: Sanjana Kapur <[email protected]>
Co-authored-by: Shiran Pasternak <[email protected]>

* April a11y Bug Fixes (#2523)

* Fix AB#502: The Name property of a focusable element must not be null

* Fix AB#509: Focusable sibling elements must not have the same Name and LocalizedControlType

Co-authored-by: Sanjana Kapur <[email protected]>

* Prepare for release 2.14.0 (#2534)

* Updated changelog and version.

* Update changelog

Co-authored-by: rechen <[email protected]>

* Unrevert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)"

8a7424b

Batch Service supports VM SKU API so reenabling service call.

* Bump Batch Explorer to version 2.15.0

Co-authored-by: Shiran Pasternak <[email protected]>
Co-authored-by: rechen <[email protected]>
Co-authored-by: David Watrous <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Sanjana Kapur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants