Update builds to Node.js 16 and NPM 7#2388
Merged
Conversation
dpwatrous
requested review from
bgklein,
cRui861,
gingi,
paterasMSFT and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 903 903
Lines 26024 26024
Branches 5115 5115
=======================================
Hits 16983 16983
Misses 9041 9041 Continue to review full report at Codecov.
|
dpwatrous
force-pushed
the
dpwatrous/npm-update
branch
from
4e51fec to
2763661
Compare
dpwatrous
force-pushed
the
dpwatrous/npm-update
branch
from
2763661 to
f7289f9
Compare
cRui861
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 16 is becoming the LTS version on October 26th: https://nodejs.org/en/about/releases/
Also needed to update electron-builder to get the builds working with Node 16, and removed some unneeded @types dependencies which were causing warnings on install.