Skip to content

Fix: Unable to log in with personal (MSA) accounts#2354

Merged
dpwatrous merged 2 commits intomasterfrom
dpwatrous/msa-auth-fix
Jul 29, 2021
Merged

Fix: Unable to log in with personal (MSA) accounts#2354
dpwatrous merged 2 commits intomasterfrom
dpwatrous/msa-auth-fix

Conversation

@dpwatrous
Copy link
Member

Fixes #2344

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #2354 (d39569e) into master (ca3a3ba) will not change coverage.
The diff coverage is n/a.

❗ Current head d39569e differs from pull request most recent head 8e9ac92. Consider uploading reports for the commit 8e9ac92 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files         903      903           
  Lines       26024    26024           
  Branches     5115     5115           
=======================================
  Hits        16977    16977           
  Misses       9047     9047           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3a3ba...8e9ac92. Read the comment docs.

@dpwatrous dpwatrous enabled auto-merge (squash) July 29, 2021 14:08
@dpwatrous dpwatrous disabled auto-merge July 29, 2021 14:14
@dpwatrous dpwatrous enabled auto-merge July 29, 2021 14:14
@dpwatrous dpwatrous disabled auto-merge July 29, 2021 14:14
Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially like the unhardcoding of "common", which would have made the change work when I tried it. 😉

@dpwatrous dpwatrous enabled auto-merge July 29, 2021 14:38
@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dpwatrous dpwatrous merged commit 11ad6b6 into master Jul 29, 2021
@dpwatrous dpwatrous deleted the dpwatrous/msa-auth-fix branch July 29, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to login with my personal account.

2 participants