Skip to content

Dynamically show/hide cloud services deprecation warning#2351

Merged
dpwatrous merged 1 commit intomasterfrom
dpwatrous/dynamic-dep-warning
Jul 22, 2021
Merged

Dynamically show/hide cloud services deprecation warning#2351
dpwatrous merged 1 commit intomasterfrom
dpwatrous/dynamic-dep-warning

Conversation

@dpwatrous
Copy link
Member

Only show when a Cloud Services image is selected

Screenshots:

Screen Shot 2021-07-21 at 8 26 00 AM

Screen Shot 2021-07-21 at 8 28 26 AM

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2351 (c96b1a9) into master (95b7856) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
- Coverage   65.23%   65.23%   -0.01%     
==========================================
  Files         903      903              
  Lines       26021    26023       +2     
  Branches     5114     5115       +1     
==========================================
  Hits        16976    16976              
- Misses       9045     9047       +2     
Impacted Files Coverage Δ
...l/action/add/pool-create-basic-dialog.component.ts 10.18% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b7856...c96b1a9. Read the comment docs.

@dpwatrous dpwatrous enabled auto-merge (squash) July 22, 2021 18:32
@dpwatrous dpwatrous merged commit ad01876 into master Jul 22, 2021
@dpwatrous dpwatrous deleted the dpwatrous/dynamic-dep-warning branch July 22, 2021 19:08
@cRui861
Copy link
Member

cRui861 commented Aug 5, 2021

Fixes #2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants