Skip to content

Fix sort icon luminosity contrast ratio too low#2349

Merged
cRui861 merged 2 commits intomasterfrom
rechen/bug282
Jul 29, 2021
Merged

Fix sort icon luminosity contrast ratio too low#2349
cRui861 merged 2 commits intomasterfrom
rechen/bug282

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Jul 3, 2021

The sort icon color contrast (5.7:1) is the same as the label as shown in the screenshot below. When clicked, it turns blue.
image

@codecov
Copy link

codecov bot commented Jul 3, 2021 •
edited
Loading

Codecov Report

Merging #2349 (7f4012f) into master (11ad6b6) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f4012f differs from pull request most recent head 6ccce24. Consider uploading reports for the commit 6ccce24 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2349   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files         903      903           
  Lines       26024    26024           
  Branches     5115     5115           
=======================================
  Hits        16977    16977           
  Misses       9047     9047

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ad6b6...6ccce24. Read the comment docs.

@dpwatrous
Copy link
Member

dpwatrous commented Jul 22, 2021

Is the new behavior that the color doesn't change when you focus the column header?

@cRui861
Copy link
Member Author

cRui861 commented Jul 27, 2021

@dpwatrous Yes, the previous behavior made the gray color of the arrows lighter when hovering over the column names so there wasn't as great of a contrast:
image

@dpwatrous
Copy link
Member

dpwatrous commented Jul 29, 2021

@cRui861 Gotcha - looks good to me, then!

@cRui861 cRui861 enabled auto-merge (squash) July 29, 2021 17:55
@cRui861 cRui861 merged commit 84f940f into master Jul 29, 2021
@cRui861 cRui861 deleted the rechen/bug282 branch July 29, 2021 18:13
@cRui861
Copy link
Member Author

cRui861 commented Aug 5, 2021

Included in #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@gingi gingi Awaiting requested review from gingi gingi is a code owner

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cRui861 @dpwatrous