Skip to content

Fix tooltip doesn't close with esc key#2345

Merged
cRui861 merged 2 commits intomasterfrom
rechen/bug320
Jul 1, 2021
Merged

Fix tooltip doesn't close with esc key#2345
cRui861 merged 2 commits intomasterfrom
rechen/bug320

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Jun 30, 2021

Tooltip now collapses when esc key is pressed during hover.

@cRui861 cRui861 changed the title Fixes Sev1 AB#320: Tooltip doesn't close with esc key Fixes Sev1 AB#320 and AB#305: Tooltip doesn't close with esc key Jun 30, 2021
* Update tests
* Reverted dependency update
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #2345 (bcb6912) into master (34dc5ec) will not change coverage.
The diff coverage is n/a.

❗ Current head bcb6912 differs from pull request most recent head 0754353. Consider uploading reports for the commit 0754353 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files         903      903           
  Lines       26021    26021           
  Branches     5114     5114           
=======================================
  Hits        16976    16976           
  Misses       9045     9045           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dc5ec...0754353. Read the comment docs.

@cRui861 cRui861 changed the title Fixes Sev1 AB#320 and AB#305: Tooltip doesn't close with esc key Fixes tooltip doesn't close with esc key Jul 1, 2021
@cRui861 cRui861 changed the title Fixes tooltip doesn't close with esc key Fix tooltip doesn't close with esc key Jul 1, 2021
@cRui861 cRui861 merged commit 5d20f38 into master Jul 1, 2021
@cRui861 cRui861 deleted the rechen/bug320 branch July 1, 2021 22:34
@cRui861
Copy link
Member Author

cRui861 commented Aug 5, 2021

Included in #2358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants