AB#459: Added 'aria-selected' tag for clickable elements#2324
Merged
AB#459: Added 'aria-selected' tag for clickable elements#2324
Conversation
skapur12
requested review from
cRui861,
dpwatrous,
gingi,
paterasMSFT and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
=======================================
Coverage 65.28% 65.28%
=======================================
Files 903 903
Lines 25756 25756
Branches 5114 5114
=======================================
Hits 16815 16815
Misses 8941 8941
Continue to review full report at Codecov.
|
cRui861
reviewed
May 26, 2021
skapur12
changed the title
cRui861
reviewed
May 27, 2021
cRui861
previously approved these changes
May 27, 2021
Member
|
Make sure to squash and merge when merging into master |
cRui861
approved these changes
May 28, 2021
Member
|
Included in #2358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This screenshot displays how the aria-selected tag for the 3ds Max button is set to 'true' (because the user has selected that button), whereas for all other buttons on the page, the tag is set to 'false.'