Fix InvalidApplicationLicense error when selecting vray-rt software#2298
Merged
Fix InvalidApplicationLicense error when selecting vray-rt software#2298
Conversation
Added an API version for listing compute SKUs
* Check for response.value always 0 indexed * Clean up console logs
* Update vmSize test suite for new response data
* Merged V-Ray and V-Ray RT into the same option
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT and
zfengms
as code owners
gingi
previously approved these changes
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #2298 +/- ##
==========================================
+ Coverage 65.19% 65.25% +0.06%
==========================================
Files 903 904 +1
Lines 25712 25757 +45
Branches 5105 5113 +8
==========================================
+ Hits 16763 16809 +46
+ Misses 8949 8948 -1
Continue to review full report at Codecov.
|
zfengms
reviewed
Mar 12, 2021
| compute: "2019-03-01", | ||
| compute: { | ||
| default: "2019-03-01", | ||
| skus: "2019-04-01", |
Contributor
There was a problem hiding this comment.
Any reason we can't remove default and use 2019-04-01 for all compute api calls?
Member
Author
There was a problem hiding this comment.
Dave and I took a look at this and it seems like sometimes the APIs within the Compute API sometimes has different versioning so we did this to modularize and for more specific testing.
zfengms
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users now can select one option for vray and vray-rt:
