Skip to content

Fix freezing issue for 'pause on exceptions' in splash screen#2296

Merged
cRui861 merged 1 commit intomasterfrom
feature/devtools-popout-devmode
Mar 17, 2021
Merged

Fix freezing issue for 'pause on exceptions' in splash screen#2296
cRui861 merged 1 commit intomasterfrom
feature/devtools-popout-devmode

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Mar 11, 2021

Add undocked mode for devtools when running Batch Explorer in development mode. When selecting 'pause on exceptions' in devtools, Batch Explorer would freeze at splash screen but devtools wasn't visible.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2296 (ae59643) into master (597db9a) will increase coverage by 0.06%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   65.19%   65.25%   +0.06%     
==========================================
  Files         903      904       +1     
  Lines       25712    25748      +36     
  Branches     5105     5110       +5     
==========================================
+ Hits        16763    16802      +39     
+ Misses       8949     8946       -3     
Impacted Files Coverage Δ
...tch-flask/core/data/entity-getter/entity-getter.ts 93.33% <ø> (ø)
.../@batch-flask/core/data/list-getter/list-getter.ts 97.87% <ø> (ø)
src/@batch-flask/core/record/decorators.ts 89.65% <ø> (ø)
src/@batch-flask/extensions/array.ts 94.73% <ø> (ø)
src/@batch-flask/extensions/string.ts 100.00% <ø> (ø)
src/@batch-flask/ui/form/input/input.directive.ts 82.89% <ø> (ø)
src/@batch-flask/ui/loading/loading.component.ts 75.00% <0.00%> (ø)
...h-flask/ui/testing/editor/editor.testing.module.ts 76.47% <ø> (ø)
...ces/azure-batch/certificate/certificate.service.ts 70.78% <ø> (ø)
...s/azure-batch/job-schedule/job-schedule.service.ts 54.54% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f70ba7...80b91f3. Read the comment docs.

dpwatrous
dpwatrous previously approved these changes Mar 11, 2021
@cRui861 cRui861 force-pushed the feature/devtools-popout-devmode branch from 8927b45 to 80b91f3 Compare March 12, 2021 23:24
@cRui861 cRui861 merged commit d9ca6aa into master Mar 17, 2021
@cRui861 cRui861 deleted the feature/devtools-popout-devmode branch March 17, 2021 20:02
@cRui861 cRui861 linked an issue Apr 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add undocked mode for devtools to fix freezing issue

3 participants