Skip to content

Simplified ESLint#2295

Merged
gingi merged 1 commit intomasterfrom
feature/simplified-eslint
Mar 12, 2021
Merged

Simplified ESLint#2295
gingi merged 1 commit intomasterfrom
feature/simplified-eslint

Conversation

@gingi
Copy link
Member

@gingi gingi commented Mar 10, 2021

Extracts a common eslintrc with pared down rules, and adds BatchExplorer-specific rules (e.g., angular templates).

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2295 (379173e) into master (597db9a) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2295   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files         903      903           
  Lines       25712    25713    +1     
  Branches     5105     5106    +1     
=======================================
+ Hits        16763    16764    +1     
  Misses       8949     8949           
Impacted Files Coverage Δ
...tch-flask/core/data/entity-getter/entity-getter.ts 93.33% <ø> (ø)
.../@batch-flask/core/data/list-getter/list-getter.ts 97.87% <ø> (ø)
src/@batch-flask/core/record/decorators.ts 89.65% <ø> (ø)
src/@batch-flask/extensions/array.ts 94.73% <ø> (ø)
src/@batch-flask/extensions/string.ts 100.00% <ø> (ø)
src/@batch-flask/ui/form/input/input.directive.ts 82.89% <ø> (ø)
src/@batch-flask/ui/loading/loading.component.ts 75.00% <0.00%> (ø)
...h-flask/ui/testing/editor/editor.testing.module.ts 76.47% <ø> (ø)
...ces/azure-batch/certificate/certificate.service.ts 70.78% <ø> (ø)
...s/azure-batch/job-schedule/job-schedule.service.ts 54.54% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42894a5...abac8fb. Read the comment docs.

Also suppresses warnings in `npm run eslint`
@gingi gingi force-pushed the feature/simplified-eslint branch from 4eca1ab to abac8fb Compare March 11, 2021 17:30
@gingi gingi merged commit 286a2c8 into master Mar 12, 2021
@gingi gingi deleted the feature/simplified-eslint branch March 12, 2021 21:27
@cRui861 cRui861 linked an issue Apr 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify ESLint

2 participants