Update to Resource Skus to retrieve vm size data#2294
Merged
Conversation
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
+ Coverage 65.19% 65.25% +0.06%
==========================================
Files 903 904 +1
Lines 25712 25748 +36
Branches 5105 5110 +5
==========================================
+ Hits 16763 16802 +39
+ Misses 8949 8946 -3
Continue to review full report at Codecov.
|
cRui861
force-pushed
the
feature/resource-skus
branch
from
3bd1ebf to
ee739ad
Compare
Added an API version for listing compute SKUs
* Check for response.value always 0 indexed * Clean up console logs
* Update vmSize test suite for new response data
gingi
force-pushed
the
feature/resource-skus
branch
from
d53d696 to
1ee8e66
Compare
gingi
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to resourceSKU API data (https://docs.microsoft.com/en-us/rest/api/compute/resourceskus/list#resourcesku) to retrieve VM size information.
numberOfGpusto vm size model for GPU data retrieval