Conversation
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](socketio/socket.io@2.3.0...2.4.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add zfengms and remove bgklein
* Hotfix for classic vnet not found issue * Update tslint rules * Small linting fix
…ection (#2262) * Fix typo in container settings * WIP: adding taskSlotsPerNode validators based on vmSize settings * Add validators for max allowed slot amount per VM size with dynamic checking as users pick different VM sizes * add validator for min allowed slots * Update tslint rules * Fix linting issues
Bumps [electron](https://github.com/electron/electron) from 9.3.1 to 9.4.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.3.1...v9.4.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixed typo in the connection status label
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
Fixes task download button
As a security measure, Electron 9.0.0 stopped enabling the `file://` protocol when `webSecurity` is set to `false`. See electron/electron#23757 Closes #2274: Restores image previews in Task Output.
Also corrects focus outline.
Adds explicit file:// protocol support
Addresses high-severity accessibility issues.
Replaces TSLint with ESLint
This changed in Electron 9. See this issue: electron/electron#23664
Prepare for release 2.9.0
gingi
requested review from
cRui861,
dpwatrous and
paterasMSFT
as code owners
Codecov Report
@@ Coverage Diff @@
## stable #2288 +/- ##
==========================================
- Coverage 65.23% 65.19% -0.05%
==========================================
Files 903 903
Lines 25684 25712 +28
Branches 5097 5105 +8
==========================================
+ Hits 16756 16763 +7
- Misses 8928 8949 +21
Continue to review full report at Codecov.
|
cRui861
approved these changes
Feb 24, 2021
This was referenced Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.