Explicitly disable CORS when running the local dev server#2284
Merged
Explicitly disable CORS when running the local dev server#2284
Conversation
This changed in Electron 9. See this issue: electron/electron#23664
dpwatrous
requested review from
cRui861,
gingi,
paterasMSFT and
zfengms
as code owners
cRui861
approved these changes
Feb 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 903 903
Lines 25712 25712
Branches 5105 5105
=======================================
Hits 16763 16763
Misses 8949 8949 Continue to review full report at Codecov.
|
zfengms
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changed in Electron 9. See this issue: electron/electron#23664