Skip to content

Replaces TSLint with ESLint#2283

Merged
gingi merged 6 commits intomasterfrom
feature/eslint
Feb 16, 2021
Merged

Replaces TSLint with ESLint#2283
gingi merged 6 commits intomasterfrom
feature/eslint

Conversation

@gingi
Copy link
Member

@gingi gingi commented Feb 16, 2021

Initial migration with the tslint-to-eslint-config tool. Loosely based on VSCode's migration guidance. TSLint formatting is replaced with Prettier. Initial migration replaces most TSLint rules with ESLint rules as well as inline TSLint comments. Several steps required manual migration:

  • Customizations and special rules (for example, disallowing app/ and common/ imports from within @batch-flask)
  • Overriding some default ESLint behavior errors to warnings to reproduce TSLint configuration
  • Removal of some explicit rules that are handled by default plugins (e.g., eslint:recommended)
  • Fixes a handful of minor TypeScript-related linting errors

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #2283 (5202b6f) into master (a958619) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
- Coverage   65.19%   65.19%   -0.01%     
==========================================
  Files         903      903              
  Lines       25707    25712       +5     
  Branches     5102     5105       +3     
==========================================
+ Hits        16760    16763       +3     
- Misses       8947     8949       +2     
Impacted Files Coverage Δ
...-flask/core/aad/access-token/access-token.model.ts 91.66% <ø> (ø)
src/@batch-flask/core/constants.ts 100.00% <ø> (ø)
...tch-flask/core/data/entity-getter/entity-getter.ts 93.33% <ø> (ø)
src/@batch-flask/core/i18n/locale.service.ts 100.00% <ø> (ø)
...tch-flask/core/key-navigator/list-key-navigator.ts 99.18% <ø> (ø)
src/@batch-flask/core/keys.ts 100.00% <ø> (ø)
src/@batch-flask/core/list/selectable-list.ts 100.00% <ø> (ø)
src/@batch-flask/core/record/decorators.ts 89.65% <ø> (ø)
src/@batch-flask/core/record/record.ts 90.16% <ø> (ø)
src/@batch-flask/core/telemetry/telemetry.model.ts 100.00% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56cb89...d7faf4b. Read the comment docs.

@gingi gingi enabled auto-merge February 16, 2021 18:17
@gingi gingi merged commit 8f5c57d into master Feb 16, 2021
@gingi gingi deleted the feature/eslint branch February 16, 2021 19:15
@gingi gingi restored the feature/eslint branch February 16, 2021 19:24
@dpwatrous dpwatrous deleted the feature/eslint branch February 16, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant