Merged
Conversation
As a security measure, Electron 9.0.0 stopped enabling the `file://` protocol when `webSecurity` is set to `false`. See electron/electron#23757 Closes #2274: Restores image previews in Task Output.
gingi
requested review from
cRui861,
dpwatrous,
paterasMSFT and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2277 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 903 903
Lines 25707 25707
Branches 5102 5102
=======================================
Hits 16760 16760
Misses 8947 8947 Continue to review full report at Codecov.
|
dpwatrous
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a security measure, Electron 9.0.0 stopped enabling the
file://protocol whenwebSecurityis set tofalse. See electron/electron#23757Closes #2274: Restores image previews in Task Output.