Variable Slots - max and min validators based on taskSlotsPerNode selection#2262
Merged
Variable Slots - max and min validators based on taskSlotsPerNode selection#2262
Conversation
…hecking as users pick different VM sizes * add validator for min allowed slots
cRui861
requested review from
bgklein,
dpwatrous,
gingi and
paterasMSFT
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2262 +/- ##
==========================================
- Coverage 65.23% 65.19% -0.05%
==========================================
Files 903 903
Lines 25693 25704 +11
Branches 5102 5101 -1
==========================================
- Hits 16761 16757 -4
- Misses 8932 8947 +15
Continue to review full report at Codecov.
|
zfengms
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add max and min validators based on taskSlotsPerNode and vmSize selection.
New "Pool Details" and "Optional Settings" UI:
taskSlotsPerNode default maximum validator is 256:
taskSlotsPerNode default minimum validator is 1:
Max validator error message changes dynamically depending on the vmSize chosen by user and taskSlotsPerNode inputted:
