Fix occasional MacOS freezing issue on application startup#2237
Merged
Fix occasional MacOS freezing issue on application startup#2237
Conversation
Accessing Window.id after a window has been destroyed throws an error. Prevent this by checking if the window is destroyed first.
…processes at the same time
This fixes a race condition which could cause freezes on MacOS See: paulmillr/chokidar#434
dpwatrous
requested review from
bgklein,
cRui861,
gingi and
paterasMSFT
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
=======================================
Coverage 65.23% 65.23%
=======================================
Files 903 903
Lines 25693 25693
Branches 5102 5102
=======================================
Hits 16761 16761
Misses 8932 8932 Continue to review full report at Codecov.
|
cRui861
approved these changes
Jan 6, 2021
cRui861
force-pushed
the
bugfix/macos-freeze
branch
from
ef760be to
37b5261
Compare
Member
|
Fixed #2254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have been caused by a bug in chokidar: paulmillr/chokidar#434
Also included some development process improvements: