Skip to content

Accessibility M1: Fix luminosity contrast issues#2236

Merged
cRui861 merged 1 commit intomasterfrom
bugfix/accessibility-m1
Dec 16, 2020
Merged

Accessibility M1: Fix luminosity contrast issues#2236
cRui861 merged 1 commit intomasterfrom
bugfix/accessibility-m1

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Dec 15, 2020

Fix color contrast ratio issue for 'Low Priority' on graphs for Batch accounts AD#434:
image

Fix color contrast ratio issue for account naming suffix when creating a new Batch account AD#437 :
image

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2236 (de98170) into master (014a4e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2236   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files         903      903           
  Lines       25693    25693           
  Branches     5102     5102           
=======================================
  Hits        16761    16761           
  Misses       8932     8932           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014a4e7...de98170. Read the comment docs.

@dpwatrous
Copy link
Member

Looks good to me, let's just clean up the commit messages a bit and tag them with their ADO work item IDs (ie: "Fixes AB#1234)

Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See my comment above)

Fixes AB#467: Contrast on InfoBox background
Fixes AB#434: Low Priority text contrast issues
Fixes AB#437: Account name suffix luminosity contrast issue
@cRui861 cRui861 force-pushed the bugfix/accessibility-m1 branch from ed67b38 to de98170 Compare December 16, 2020 20:28
@dpwatrous dpwatrous self-requested a review December 16, 2020 20:34
@cRui861 cRui861 merged commit 373fb50 into master Dec 16, 2020
@cRui861 cRui861 deleted the bugfix/accessibility-m1 branch December 16, 2020 20:53
@cRui861 cRui861 modified the milestone: 2.8.0 Jan 14, 2021
@cRui861
Copy link
Member Author

cRui861 commented Jan 15, 2021

Fixed #2253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants