Variable slot pricing - update and fix breaking API changes#2230
Variable slot pricing - update and fix breaking API changes#2230
Conversation
* Todo: Update template.json files with remaining maxtaskpernode variable
* Update JobProgressStatusComponent tests
* Update BatchService api version to latest * Todo: Fix any breaking changes from api update * WIP: working on requiredSlots changes for job and tasks
cRui861
requested review from
bgklein,
dpwatrous,
gingi and
paterasMSFT
as code owners
src/app/components/job/details/job-progress-status/job-progress-status.component.spec.ts
Outdated
Show resolved
Hide resolved
|
Only glimpsed over the code, but does this address the pool view (of nodes in the pool) where currently running tasks are displayed as a percentage of the VM as green? |
There are plans to add the task slot counts in the heatmap UI within the Pool blade but it'll probably come in a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
+ Coverage 65.14% 65.16% +0.02%
==========================================
Files 899 903 +4
Lines 25660 25688 +28
Branches 5092 5098 +6
==========================================
+ Hits 16715 16739 +24
- Misses 8945 8949 +4
Continue to review full report at Codecov.
|
| this._baseFormControls["displayName"] = [null]; | ||
| this._baseFormControls["killJobOnCompletion"] = [true]; | ||
| this._baseFormControls["runExclusive"] = [true]; | ||
| this._baseFormControls["requiredSlots"] = [1, [Validators.required, Validators.min(1)]]; |
There was a problem hiding this comment.
We may want to add a max value validator based on pool taskSlotsPerNode settings, but it can be done in another PR.
There was a problem hiding this comment.
The max value validator based on pool taskSlotsPerNode would be based on the VM sizes chosen for that specific pool right? Do you know how that is determined? Like if there is information that I can pull that has a correspondence between the VM size and the max value for the taskSlotsPerNode?
There was a problem hiding this comment.
The max value for taskSlotsPerNode is 4 x number of VM cores, when vmSize is not specified, the max value is 256
|
Fixed #2251 |
4 participants
Updates for variable slot pricing feature in BatchService API version 2020-09-01.12.0:
maxTasksPerNodewithtaskSlotsPerNodeon the poolGetTaskCountsto returnTaskCountsResult, which is a complex object containing the previousTaskCountsobject and a newTaskSlotCountsobject providing similar information in the context of slots being usedrequiredSlotsto the task allowing user to specify how many slots on a node it should take up