Skip to content

Added delete button to left-hand node list#2229

Merged
dpwatrous merged 1 commit intomasterfrom
dpwatrous/delete-nodes
Oct 19, 2020
Merged

Added delete button to left-hand node list#2229
dpwatrous merged 1 commit intomasterfrom
dpwatrous/delete-nodes

Conversation

@dpwatrous
Copy link
Member

This allows multi-select deletion (and matches other left-hand lists like the pools list)

This allows multi-select deletion (and matches other left-hand lists like the pools list)
@dpwatrous
Copy link
Member Author

Screenshot:
image

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #2229 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
- Coverage   65.14%   65.13%   -0.01%     
==========================================
  Files         899      899              
  Lines       25660    25662       +2     
  Branches     5092     5092              
==========================================
  Hits        16715    16715              
- Misses       8945     8947       +2     
Impacted Files Coverage Δ
.../app/components/node/browse/node-list.component.ts 17.94% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb2b84...f486fdf. Read the comment docs.

Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great -- and tiny -- change!

@dpwatrous dpwatrous merged commit b14680e into master Oct 19, 2020
@dpwatrous dpwatrous deleted the dpwatrous/delete-nodes branch October 19, 2020 14:47
@cRui861 cRui861 modified the milestone: 2.8.0 Jan 14, 2021
@cRui861
Copy link
Member

cRui861 commented Jan 15, 2021

Fixed #2250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants