Replace hyphens in the build number with underscores#2227
Merged
Conversation
dpwatrous
requested review from
bgklein,
cRui861,
gingi and
paterasMSFT
as code owners
Fixes AB#379 When manually building a PR branch, underscores would cause the RPM build to fail.
dpwatrous
force-pushed
the
dpwatrous/rpm-hyphen-fix
branch
from
fef1672 to
71c3e8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 899 899
Lines 25660 25660
Branches 5092 5092
=======================================
Hits 16715 16715
Misses 8945 8945 Continue to review full report at Codecov.
|
paterasMSFT
approved these changes
Oct 16, 2020
Member
|
Fixed #2249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When manually building a PR branch, underscores would cause the RPM
build to fail