Update karma-coverage and remove karma-remap-coverage#2219
Merged
Conversation
dpwatrous
requested review from
bgklein,
cRui861,
gingi and
paterasMSFT
as code owners
dpwatrous
force-pushed
the
dpwatrous/karma-coverage-update
branch
from
69507dd to
696d206
Compare
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
==========================================
- Coverage 65.28% 65.23% -0.05%
==========================================
Files 903 903
Lines 25756 26021 +265
Branches 5114 5114
==========================================
+ Hits 16815 16976 +161
- Misses 8941 9045 +104
Continue to review full report at Codecov.
|
Member
Author
|
Setting as a draft since there are issues with code coverage |
paterasMSFT
previously approved these changes
Nov 24, 2020
This resolves some `npm audit` warnings and uses a non-deprecated version of Istanbul. Also removed karma-remap-coverage as it does not support karma-coverage >= 2.0
dpwatrous
force-pushed
the
dpwatrous/karma-coverage-update
branch
from
696d206 to
d4e2122
Compare
Member
Author
|
I'm not sure why there's some minor coverage changes (maybe just changes/fixes between versions of karma-coverage), but the source mapping seems to be working just fine. Marking as ready to review. |
gingi
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves some
npm auditwarnings and uses a non-deprecated version of Istanbul. Also removed karma-remap-coverage as it does not support karma-coverage >= 2.0