Merged
Conversation
mahilleb-msft
requested review from
bgklein,
cRui861,
dpwatrous,
gingi and
paterasMSFT
as code owners
dpwatrous
approved these changes
Aug 18, 2020
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
Thanks for catching that! Seems like we have an unrelated permissions issue with the CI build that's blocking this PR. Looking into that, then I'll merge this.
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
=======================================
Coverage 65.13% 65.13%
=======================================
Files 899 899
Lines 25654 25654
Branches 5090 5090
=======================================
Hits 16710 16710
Misses 8944 8944 Continue to review full report at Codecov.
|
Member
|
The CI issue is an ADO configuration issue we'll have to figure out separately (I ran against this same PR branch and everything passed). Went ahead and merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.