Skip to content

Feature: Better encoding support#1389

Merged
timotheeguerin merged 12 commits intomasterfrom
feature/encoding
May 30, 2018
Merged

Feature: Better encoding support#1389
timotheeguerin merged 12 commits intomasterfrom
feature/encoding

Conversation

@timotheeguerin
Copy link
Member

fix #875

@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #1389 into master will increase coverage by 0.06%.
The diff coverage is 64.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
+ Coverage   53.72%   53.78%   +0.06%     
==========================================
  Files        1004     1006       +2     
  Lines       23721    23812      +91     
  Branches     2722     2747      +25     
==========================================
+ Hits        12743    12807      +64     
- Misses      10978    11005      +27
Impacted Files Coverage Δ
src/@batch-flask/utils/encoding/index.ts 100% <100%> (ø)
src/@batch-flask/utils/index.ts 100% <100%> (ø) ⬆️
app/services/batch-api/fileProxy.ts 7.01% <16.66%> (+1.35%) ⬆️
app/services/storage/blob-storage-client-proxy.ts 1.86% <4.76%> (+0.78%) ⬆️
src/@batch-flask/utils/encoding/encoding.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fd91a...220ef96. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 496d6c1 into master May 30, 2018
@timotheeguerin timotheeguerin deleted the feature/encoding branch May 30, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read file support different encoding

1 participant