List view loads from cache but always query server right away to check for changes#1066
Merged
timotheeguerin merged 2 commits intomasterfrom Feb 14, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 53.59% 53.59% +<.01%
==========================================
Files 848 848
Lines 20210 20208 -2
Branches 2276 2276
==========================================
Hits 10831 10831
+ Misses 9379 9377 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1065
Currently if data was in the cache it would load from there but not update with server data unless explicitly refershed which leads to weird data if deleting a job and recreating and navigating to it seeing deleted job task.
Still try to load from cache to have a fast loading if quickly switching between elements.
Could maybe add a timestamp to the cache and not even try to load from it if the data is too old