Skip to content

Feature: Json themes. allow user to defined custom themes#1013

Merged
timotheeguerin merged 25 commits intomasterfrom
feature/json-themes
Jan 18, 2018
Merged

Feature: Json themes. allow user to defined custom themes#1013
timotheeguerin merged 25 commits intomasterfrom
feature/json-themes

Conversation

@timotheeguerin
Copy link
Member

fix #1012

Theming is still quite limited but this get the theming started.

@codecov
Copy link

codecov bot commented Jan 18, 2018

Codecov Report

Merging #1013 into master will decrease coverage by 0.18%.
The diff coverage is 38.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   54.82%   54.63%   -0.19%     
==========================================
  Files         765      769       +4     
  Lines       18235    18434     +199     
  Branches     2082     2092      +10     
==========================================
+ Hits         9997    10072      +75     
- Misses       8238     8362     +124
Impacted Files Coverage Δ
app/core/dynamic-form.ts 46.66% <ø> (ø) ⬆️
app/services/fs.service.ts 12.5% <0%> (-1.14%) ⬇️
app/components/base/charts/helpers.ts 23.52% <0%> (ø) ⬆️
...g-time-graph/tasks-running-time-graph.component.ts 18.18% <10%> (-0.1%) ⬇️
app/services/index.ts 100% <100%> (ø) ⬆️
.../notifications/notification-container.component.ts 100% <100%> (ø) ⬆️
app/services/themes/index.ts 100% <100%> (ø)
...nents/base/notifications/notification.component.ts 63.33% <100%> (ø) ⬆️
app/services/themes/theme.service.ts 14.28% <14.28%> (ø)
app/services/themes/theme-core.ts 41.66% <41.66%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1839e...fd388ce. Read the comment docs.

@timotheeguerin timotheeguerin merged commit d7c017c into master Jan 18, 2018
@timotheeguerin timotheeguerin deleted the feature/json-themes branch January 18, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the theming system to use json instead of scss

1 participant