Possible fix for the issue #4516#4525
Merged
aprakash13 merged 4 commits intoAzure:masterfrom Apr 22, 2022
Merged
Conversation
Possible fix for the issue Azure#4516
samikroy
requested review from
aprakash13,
ashwin-patil,
juliango2100,
oshezaf,
petebryan,
shainw,
thmcelro and
timbMSFT
as code owners
Contributor
Author
|
@aprakash13 - This is possible fix for #4516 |
Contributor
|
@aprakash13 Please review and provide your feedback. thanks!!! |
aprakash13
suggested changes
Apr 22, 2022
Contributor
aprakash13
left a comment
aprakash13
left a comment
There was a problem hiding this comment.
Thanks @samikroy.
Event is not a valid connector Id. The connectorId should still be SecurityEvents. Below is the list of valid connectors that the validation scripts recognize.
https://github.com/Azure/Azure-Sentinel/blob/master/.script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json
Contributor
Author
|
Thank you @aprakash13 for sharing the reference & merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for the issue #4516