Skip to content

Fix build project#482

Merged
cbersch merged 2 commits into
mainfrom
cbersch/fix-build-project
Apr 22, 2026
Merged

Fix build project#482
cbersch merged 2 commits into
mainfrom
cbersch/fix-build-project

Conversation

@cbersch

@cbersch cbersch commented Apr 21, 2026

Copy link
Copy Markdown
Member
  • Adding explicit references to use nuget packages without known vulnerabilities

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Legal checklist

  • This work is entirely original, it is not derived from any existing code incompatible with the Apache 2.0 License, like FluentAssertions.

@cbersch
Fix build project
8bd59c0 
* Adding explicit references to use nuget packages without known vulnerabilities
@github-actions

github-actions Bot commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    75 files  ±0      75 suites  ±0   4m 5s ⏱️ +47s
 6 296 tests ±0   6 296 ✅ ±0  0 💤 ±0  0 ❌ ±0 
58 459 runs  ±0  58 459 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b54fe4. ± Comparison against base commit 3d4989f.

This pull request removes 10 and adds 8 tests. Note that renamed tests count towards both. 
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
Object name: 'GetPositionExceptionMessage'.)

AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
AwesomeAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)

♻️ This comment has been updated with latest results.

@coveralls

coveralls commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 24711697934

Coverage remained the same at 97.885%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 12897
Covered Lines: 12742
Line Coverage: 98.8%
Relevant Branches: 4032
Covered Branches: 3829
Branch Coverage: 94.97%
Branches in Coverage %: Yes
Coverage Strength: 39359.81 hits per line
💛 - Coveralls

@lg2de

lg2de commented Apr 21, 2026

Copy link
Copy Markdown
Member

I do not see any build problem in the last MAIN build!?

@cbersch
cbersch requested a review from a team April 21, 2026 07:40
@cbersch

cbersch commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

I do not see any build problem in the last MAIN build!?

All dependency update PRs fail because of this.

lg2de
lg2de approved these changes Apr 21, 2026
View reviewed changes

@lg2de lg2de left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend more detailed comment.
We do not know when an how Nuke will be updated to fix these vulnerabilities. Later it may be more difficult to map one comment to two packages.

Comment thread Build/_build.csproj Outdated
@cbersch @lg2de
Update Build/_build.csproj
3b54fe4 
Co-authored-by: Lukas Grützmacher <[email protected]>
@IT-VBFK

IT-VBFK commented Apr 21, 2026

Copy link
Copy Markdown
Member

I vote for moving along to a fork: https://github.com/gruke-build/src

It's a drop-in replacement

@sonarqubecloud

sonarqubecloud Bot commented Apr 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ITaluone

ITaluone commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

I vote for moving along to a fork: https://github.com/gruke-build/src

It's a drop-in replacement

I came along this repo when checking NUKE PRs and recognize a reference to a fork. But: this fork also has the same dependencies as NUKE so wouldn't make a difference for now.

But in the long term this could be it...

@cbersch
cbersch merged commit f7f87d1 into main Apr 22, 2026
14 checks passed
@cbersch
cbersch deleted the cbersch/fix-build-project branch April 22, 2026 20:34
This was referenced Jul 19, 2026
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Open
Merged
Merged
Closed
Closed
Open
Open
This was referenced Jul 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Open
Merged
Merged
Open
Closed
Closed
Open
Open
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes
@lg2de lg2de lg2de approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cbersch @coveralls @lg2de @IT-VBFK @ITaluone @ScarletKuro