Repository navigation
Commit ac19b2d
docs: clarify what a canceled partition means in the hash join dynamic filter (apache#27087)
## Which issue does this PR close?
- This PR does not close an issue. It is related to
apache#21625 and follows up on
apache#21666.
## Rationale for this change
The partitioned hash join dynamic filter coordinator marks a partition
as "canceled" when its stream is dropped before it reports its build
data. A reader can assume that this means the whole query was canceled.
That assumption is wrong. A parent operator can legally finish early and
drop one hash join partition stream while sibling partitions keep
running. In apache#21625 (the TPC-H
Q18 hang), a `RightSemi` join with an empty build side for some
partitions does exactly this. An editor who relies on the wrong reading
could reintroduce that hang.
## What changes are included in this PR?
Comment-only changes. The docs define a canceled partition by what a
reader can observe: a parent operator drops one partition's stream
before that stream reads its probe side. They avoid internal terms such
as report delivery.
- `BuildReportHandle` explains what cancellation means for the join. The
other partitions and their shared probe input keep running, a
`RepartitionExec` discards the rows routed to the canceled partition,
and the canceled stream produces no output. The other partitions stop
waiting for the canceled one.
- `PartitionStatus::CanceledUnknown` explains only what it means for the
dynamic filter. The partition's build keys are unknown, and the filter
may keep or reject the rows routed to it, because no stream joins those
rows.
- `BuildReportState::Canceled` and
`SharedBuildAccumulator::report_canceled_partition` point to those two
docs. One em-dash in an existing comment is replaced.
The last commit rewrites the earlier wording in plain terms, so
reviewing the full diff is easier than reviewing commit by commit.
## What is the testing strategy for this PR?
The changes are comment-only, so they add no tests. `cargo fmt` and
`cargo clippy -p datafusion-physical-plan --all-targets --all-features
-- -D warnings` pass.
## Are there any user-facing changes?
No.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>1 parent e7c51c7 commit ac19b2d
2 files changed
Lines changed: 43 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
374 | 385 | | |
375 | 386 | | |
376 | 387 | | |
| |||
505 | 516 | | |
506 | 517 | | |
507 | 518 | | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
508 | 524 | | |
509 | 525 | | |
510 | 526 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | | - | |
| 248 | + | |
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
| 255 | + | |
| 256 | + | |
255 | 257 | | |
256 | 258 | | |
257 | 259 | | |
258 | 260 | | |
259 | | - | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
260 | 285 | | |
261 | 286 | | |
262 | 287 | | |
| |||
0 commit comments