Fixing option null printing for record values (WIP) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@nelak look great i'm accepting this so the build on my PR work and we can see if there is testing that fails |
Author
|
@AviAvni Sure, that works for me. Later today I'll try to see if I can fix my build environment it looks I don't have it setup properly for running the tests. |
AviAvni
pushed a commit
that referenced
this pull request
Jan 26, 2018
* Add tests for C# use of FuncConvert.ToFSharpFunc * Update test.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should take care of the issue for record values.
I need to continue testing it. I'm having some issues getting the tests working for completing the use cases.
I'll let you know if I'm still stuck so you can help me getting them running