Add wpsc_cookies and wpsc_plugins filters to modify those settings #582
Conversation
These filters will allow WordPress plugins to modify the cookies and plugins lists used by WP Super Cache instead of the add/delete functions introducted in #574 and #580. Duplicate entries are removed so the filter function does not need to worry about that. Example code: `function myplugin_add_wpsc_cookies_filter( $cookies ) { $cookies[] = 'myplugin'; return $cookies; } add_filter( 'wpsc_cookies', 'myplugin_add_wpsc_cookies_filter' );` `function myplugin_delete_wpsc_cookies_filter( $cookies ) { if ( in_array( 'myplugin', $cookies ) ) { unset( $cookies[ array_search( 'myplugin', $cookies ) ] ); } return $cookies; } add_filter( 'wpsc_cookies', 'myplugin_delete_wpsc_cookies_filter' );`
|
As I've tried to explain here I think an action is more appropriate and safer than a filter. If properly used, a hook to the filter could mess with the content of An action seems to me more straight-forward. In a plugin, I could call And in wp-super-cache, function wpsc_add_cookie( $name ) {
global $wpsc_cookies;
if (
! isset( $wpsc_cookies ) ||
! is_array( $wpsc_cookies ) ||
! in_array( $name, $wpsc_cookies )
) {
$wpsc_cookies[] = $name;
wp_cache_setting( 'wpsc_cookies', $wpsc_cookies );
}
}
add_action( 'wpsc_cookies' ); |
|
Ah. I wondered about that. Your example makes sense and avoids running an apply_filters() on every page load if there's no outside code that wants to modify the cookie list. Thanks. I'll modify the PR. |
Instead of using filters to change cookie/plugin lists I've added four actions: wpsc_add_plugin wpsc_delete_plugin wpsc_add_cookie wpsc_delete_cookie For example, to add a cookie name called 'euCookie': `do_action( 'wpsc_add_cookie', 'euCookie' );` Props @andreasciamanna.
|
I updated the PR, changing the filters to actions so you can do |
|
Thanks a lot! We are a bit at the end of our development cycle, but I'll see if I can manage to include it in the next WPML bugfix release. If not, it will be included in the following one. |
|
Just tested it with Found a bug in |
|
Great. that's merged and I'll get a new release out this evening or tomorrow. |
These filters will allow WordPress plugins to modify the cookies and
plugins lists used by WP Super Cache instead of the add/delete functions
introduced in #574 and #580.
Duplicate entries are removed so the filter function does not need to
worry about that. The filters fire on 'init'.
Example filter code:
As suggested by @johnbillion and @andreasciamanna in #580.
You can also use
do_actionto add a cookie like this:Use
wpsc_delete_cookieto remove the cookie.