Run commands after_wp_load
#7
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run the CLI commands on
before_wp_load. There's a brief discussion in #4 (comment) about why we do that, which boils down to ensuring these commands work even when the WP installation is broken. However, messing with the normal WP load order like we do here (we "manually" load thesqlite-database-integrationplugin) can be problematic. For example, it caused the following bug in Studio: https://github.com/Automattic/dotcom-forge/issues/10054I need to do some more testing before we can determine if we should land this change or not, but I've confirmed that this PR fixes https://github.com/Automattic/dotcom-forge/issues/10054.
Any input from @sejas and @wojtekn is very welcome! @sejas and I already paired over this, so you're already very familiar with the problem 😊