Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Jan 7, 2025

Resolves https://github.com/Automattic/dotcom-forge/issues/10205.

Proposed Changes

  • fix broken Search box border corners
  • remove broken hover styles

ℹ️ As the PR also includes a number of minor formatting changes, I have highlighted the main changes above with inline PR comments.

Before

Screen.Capture.on.2025-01-07.at.12-02-49.mp4

After

Screen.Capture.on.2025-01-07.at.12-22-59.mp4

Why are these changes being made?

To resolve https://github.com/Automattic/dotcom-forge/issues/10205.

Testing Instructions

  1. Check out the PR branch and build the Calypso app (or use the Calypso live link).
  2. Access http://calypso.localhost:3000/setup/new-hosted-site/domains?ref=studio&section=studio-sync&showDomainStep.
  3. There should be no visible styling issue.
  4. There should be no regressions on the domain selection during the normal site creation flow, e.g. at http://calypso.localhost:3000/setup/onboarding/domains?source=sites-dashboard&ref=topbar&start_ref=https%3A%2F%2Fwordpress.com%2F&categories=blog.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Jan 7, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Comment on lines -214 to -218

&:hover {
border-bottom: 1px solid var(--studio-gray-50);
border-top: 1px solid var(--studio-gray-50);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of unnecessary styling on hover.

Comment on lines -181 to -183
&:hover {
border: var(--studio-gray-50);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of unnecessary styling on hover.

border: 1px solid var(--color-border-subtle);
border: 1px solid var( --color-border-subtle );
border-radius: 4px;
overflow: hidden;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the Search box border corners styling issue.

@ivan-ottinger ivan-ottinger requested a review from a team January 7, 2025 11:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks clear, and fixes the issue. Thanks for the cleanup!

@ivan-ottinger ivan-ottinger merged commit b575ce4 into trunk Jan 8, 2025
14 of 15 checks passed
@ivan-ottinger ivan-ottinger deleted the fix/domain-step-styling branch January 8, 2025 09:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2025
JessBoctor pushed a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants