-
Notifications
You must be signed in to change notification settings - Fork 2k
Stepper: Fix the "Choose a domain" step styling #98018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Calypso Live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
|
||
| &:hover { | ||
| border-bottom: 1px solid var(--studio-gray-50); | ||
| border-top: 1px solid var(--studio-gray-50); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of unnecessary styling on hover.
| &:hover { | ||
| border: var(--studio-gray-50); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of unnecessary styling on hover.
| border: 1px solid var(--color-border-subtle); | ||
| border: 1px solid var( --color-border-subtle ); | ||
| border-radius: 4px; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the Search box border corners styling issue.
wojtekn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks clear, and fixes the issue. Thanks for the cleanup!
Resolves https://github.com/Automattic/dotcom-forge/issues/10205.
Proposed Changes
ℹ️ As the PR also includes a number of minor formatting changes, I have highlighted the main changes above with inline PR comments.
Before
Screen.Capture.on.2025-01-07.at.12-02-49.mp4
After
Screen.Capture.on.2025-01-07.at.12-22-59.mp4
Why are these changes being made?
To resolve https://github.com/Automattic/dotcom-forge/issues/10205.
Testing Instructions
Pre-merge Checklist