Skip to content

Disable Live Preview on Atomic sites #81337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
okmttdhr merged 1 commit into from
Sep 4, 2023
Merged

Disable Live Preview on Atomic sites #81337

okmttdhr merged 1 commit into from
Sep 4, 2023

Conversation

@okmttdhr
Copy link
Contributor

@okmttdhr okmttdhr commented Sep 4, 2023 •
edited
Loading

Proposed Changes

Disable Live Preview on Atomic sites until we resolve WordPress/gutenberg#53284. c.f. pbxlJb-3Uv-p2#comment-2939

Testing Instructions

  • Create/Use an Atomic site
  • Go to the Theme showcase page
  • Click three-dots menu on the Theme Card
  • Verify the Live Preview option is not present and "Demo site" option is present instead

Pre-merge Checklist

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-79566
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-79566&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Sep 4, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
themes        +74 B  (+0.0%)       -4 B  (-0.0%)
theme         +74 B  (+0.0%)       -4 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review September 4, 2023 03:30
@okmttdhr okmttdhr requested a review from a team September 4, 2023 03:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 4, 2023
@okmttdhr okmttdhr self-assigned this Sep 4, 2023
taipeicoder
taipeicoder approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@okmttdhr okmttdhr merged commit 544d530 into trunk Sep 4, 2023
@okmttdhr okmttdhr deleted the update/live-preview-disable-atomic branch September 4, 2023 03:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 4, 2023
okmttdhr added a commit that referenced this pull request Sep 7, 2023
@okmttdhr
Revert "Disable Live Preview on Atomic sites (#81337)"
23045f3 
This reverts commit 544d530.
@okmttdhr okmttdhr mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taipeicoder taipeicoder taipeicoder approved these changes

Assignees

@okmttdhr okmttdhr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block Theme Previews does not work if we call the get_template or get_stylesheet functions early

4 participants

@okmttdhr @matticbot @taipeicoder