Support new line height setting #46792
Conversation
noahtallen
added
[Type] Bug
matticbot
added
the
[Status] Needs Review
|
cc @jorgefilipecosta @nosolosw. What would be the ideal way to handle this use case? Specifically, we are using a filter to override gutenberg editor settings to always enable the line-height settings. This is because many of the themes on WordPress.com haven't opted-in to the setting yet, even though it works fine. (Plus, we had a lot of users using the feature before it was delegated to theme support!) Is this approach fine? Is there a better way to specify what the default setting should be for that variable? |
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D51824-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Building the ETP release is apparently blocked by #46811 currently 😕 |
Disregard, applying D51824-code to my sandbox works just fine. |
There was a problem hiding this comment.
Testing via yarn dev --sync doesn't work for me because of the issue mentioned by @ockham, but after applying the corresponding diff D51824-code I was finally able to test it. All good, thanks! 🚢
matticbot
removed
the
[Status] Needs Review
| **/ | ||
| function wpcom_gutenberg_enable_custom_line_height( $settings ) { | ||
| $settings['enableCustomLineHeight'] = true; | ||
| if ( isset( $settings['__experimentalFeatures']['global']['typography'] ) ) { |
There was a problem hiding this comment.
Hi, I've already commented that this is a bug we need to fix, see WordPress/gutenberg#26537
I was thinking of a way to do it that's more robust than using __experimental.global.typography.customLineHeight (the shape of this can change as it's still experimental). What if you hook this function to after_setup_theme and make it declare theme support like add_theme_support('custom-line-height')?
Changes proposed in this Pull Request
In WordPress/gutenberg#25738, Gutenberg moved the lineHeight setting to a new place in the settings object. It also introduced a (sort of?) bug where even though it has a mechanism to use the deprecated location for the setting, it is never used because the default value is returned instead.
This simply updates our existing filter to enable line height in the new location if the new location exists. I left the old setting in place as well, just in case we still need to support older gutenberg versions.
To test:
yarn dev --sync