Skip to content

Add filter by date #103136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oandregal wants to merge 5 commits into from
Closed

Add filter by date #103136

oandregal wants to merge 5 commits into from

Conversation

@oandregal
Copy link
Contributor

@oandregal oandregal commented May 5, 2025 •
edited
Loading

DOTCOM-10618

Related: new calendar component at #102989

What

This is an early exploration to add a datetime filter.

Screen.Recording.2025-05-06.at.17.21.36.mov

Why

It's been one of the most requested features and there are some projects in production that would have used it, should it exist (e.g., hosting logs).

TODO

Follow-ups

  • Date ranges and before operators. This PR is focused on getting the basics going.

Testing Instructions

TBD

@oandregal oandregal self-assigned this May 5, 2025
@github-actions
Copy link

github-actions bot commented May 5, 2025 •
edited by matticbot
Loading

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

@matticbot
Copy link
Contributor

matticbot commented May 5, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/dataviews-filter-date on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 5, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~222 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +718 B  (+0.1%)     +203 B  (+0.1%)
entry-dashboard-a4a          +718 B  (+0.1%)     +205 B  (+0.1%)
entry-subscriptions          +583 B  (+0.0%)     +186 B  (+0.0%)
entry-stepper                +583 B  (+0.0%)     +186 B  (+0.0%)
entry-reauth-required        +583 B  (+0.0%)     +186 B  (+0.0%)
entry-main                   +583 B  (+0.0%)     +186 B  (+0.0%)
entry-login                  +583 B  (+0.0%)     +186 B  (+0.0%)
entry-domains-landing        +583 B  (+0.1%)     +186 B  (+0.1%)
entry-browsehappy            +583 B  (+0.3%)     +186 B  (+0.3%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@oandregal oandregal mentioned this pull request May 5, 2025
Merged
8 tasks
@oandregal oandregal force-pushed the add/dataviews-filter-date branch from d0c11cc to 1579ab0 Compare May 6, 2025 15:22
@oandregal
Copy link
Contributor Author

oandregal commented May 6, 2025

Some progress today: added the existing Calendar component from @automattic/components.

Screen.Recording.2025-05-06.at.17.21.36.mov

@oandregal
Copy link
Contributor Author

oandregal commented May 26, 2025

Closing this one as #103276 introduced filters per field type.

@oandregal oandregal closed this May 26, 2025
@oandregal oandregal deleted the add/dataviews-filter-date branch May 26, 2025 12:14
@chihsuan chihsuan mentioned this pull request Jun 25, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad Awaiting requested review from youknowriad youknowriad will be requested when the pull request is marked ready for review youknowriad is a code owner

Assignees

@oandregal oandregal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oandregal @matticbot