Skip to content

i18n: Remove number formatting utilities/types from i18n-calypso #102878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chriskmnds merged 3 commits into from
May 2, 2025
Merged

i18n: Remove number formatting utilities/types from i18n-calypso #102878

chriskmnds merged 3 commits into from
May 2, 2025

Conversation

@chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Apr 25, 2025 •
edited
Loading

See PT: pxLjZ-9ME-p2
Part of addressing https://github.com/Automattic/i18n-issues/issues/942
Branched off #103049

Proposed Changes

Why are these changes being made?

This is part of addressing https://github.com/Automattic/i18n-issues/issues/939 and https://github.com/Automattic/i18n-issues/issues/942, which aim at unifying number & currency-number formatting.

Testing Instructions

No functional changes. Build and tests passing.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds self-assigned this Apr 25, 2025
@chriskmnds chriskmnds requested a review from a team as a code owner April 25, 2025 09:41
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 25, 2025
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-142532
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-142532&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-142532&env=a8c-for-agencies

@chriskmnds chriskmnds mentioned this pull request Apr 25, 2025
Merged
@aduth aduth mentioned this pull request Apr 28, 2025
Merged
8 tasks
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-transform-packages branch from b3bce54 to 4c54564 Compare April 30, 2025 15:30
@chriskmnds chriskmnds requested review from a team as code owners April 30, 2025 15:30
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-transform-packages branch 2 times, most recently from a2daf0f to d1738f3 Compare April 30, 2025 16:16
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-cleanup-i18n-calypso branch from 609baf1 to fbe89e0 Compare April 30, 2025 16:55
Base automatically changed from update/i18n-number-formatters-transform-packages to trunk April 30, 2025 16:59
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-cleanup-i18n-calypso branch 2 times, most recently from 137f97a to 9e2c3c4 Compare May 1, 2025 12:03
@chriskmnds chriskmnds requested a review from a team May 1, 2025 12:26
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-cleanup-i18n-calypso branch from a8a79bb to c836698 Compare May 1, 2025 15:07
@chriskmnds chriskmnds requested a review from a team as a code owner May 1, 2025 15:07
@chriskmnds chriskmnds changed the base branch from trunk to update/i18n-number-formatters-lingering-i18n-calypso-cases May 1, 2025 15:07
@matticbot
Copy link
Contributor

matticbot commented May 1, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-number-formatters-cleanup-i18n-calypso on your sandbox.

@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-cleanup-i18n-calypso branch from c836698 to 69d9896 Compare May 1, 2025 15:31
@matticbot
Copy link
Contributor

matticbot commented May 1, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

Details 
name                   parsed_size           gzip_size
entry-subscriptions        -7767 B  (-0.4%)    -3162 B  (-0.6%)
entry-reauth-required      -7767 B  (-0.4%)    -3158 B  (-0.5%)
entry-main                 -7767 B  (-0.3%)    -3155 B  (-0.5%)
entry-login                -7767 B  (-0.3%)    -3163 B  (-0.5%)
entry-stepper              -7731 B  (-0.5%)    -3146 B  (-0.7%)
entry-domains-landing      -7676 B  (-1.1%)    -2804 B  (-1.3%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~65 bytes removed 📉 [gzipped])

Details 
name                        parsed_size           gzip_size
stepper-user-step                 -36 B  (-0.0%)      -12 B  (-0.0%)
site-migration-flow               -36 B  (-0.1%)      -13 B  (-0.1%)
async-step-use-my-domain          -36 B  (-0.0%)      -13 B  (-0.0%)
async-step-unified-plans          -36 B  (-0.0%)      -13 B  (-0.0%)
async-step-unified-domains        -36 B  (-0.0%)      -14 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~15 bytes removed 📉 [gzipped])

Details 
name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper        -36 B  (-0.0%)      -15 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-lingering-i18n-calypso-cases branch from 19e40b3 to 25b895a Compare May 2, 2025 10:21
Base automatically changed from update/i18n-number-formatters-lingering-i18n-calypso-cases to trunk May 2, 2025 10:39
@chriskmnds chriskmnds force-pushed the update/i18n-number-formatters-cleanup-i18n-calypso branch from 69d9896 to 6893f9a Compare May 2, 2025 10:40
@chriskmnds chriskmnds merged commit 39774f1 into trunk May 2, 2025
13 of 14 checks passed
@chriskmnds chriskmnds deleted the update/i18n-number-formatters-cleanup-i18n-calypso branch May 2, 2025 15:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chriskmnds chriskmnds

Labels

i18n: number-format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriskmnds @matticbot