Skip to content

Add Cache Config to enable ActivityPub support for Surge#1648

Merged
pfefferle merged 38 commits intotrunkfrom
add/surge-support
May 9, 2025
Merged

Add Cache Config to enable ActivityPub support for Surge#1648
pfefferle merged 38 commits intotrunkfrom
add/surge-support

Conversation

@pfefferle
Copy link
Member

@pfefferle pfefferle commented May 5, 2025

This adds the needed config file, so that Surge will work nicely with ActivityPub. Thanks to @kovshenin and @ocean90 for the fix:

https://dominikschilling.de/notes/http-accept-header-wordpress-cache-activitypub/

Proposed changes:

  • Add guidance to the Site-Health check, how to properly configure surge, to play nicely with ActivityPub.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Guidance for configuring Surge to support ActivityPub caching.

@pfefferle pfefferle self-assigned this May 5, 2025
@github-actions github-actions bot added [Feature] Health Check [Feature] WP Admin [Focus] Compatibility Ensuring the plugin plays well with other plugins labels May 5, 2025
@pfefferle pfefferle requested a review from obenland May 5, 2025 07:50
@pfefferle pfefferle changed the title Add guidance to enable ActivityPub support for Surge Add Cache Config to enable ActivityPub support for Surge May 6, 2025
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that looks great!

I think it's fine to keep the Site Health stuff for cases where we were unable to set the constant ourselves. Just thought we should try ourselves first.

@pfefferle
Copy link
Member Author

Thanks for the feedback @obenland... this version is so much cleaner now!

props!!

@pfefferle pfefferle requested a review from obenland May 8, 2025 14:09
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is turning out really well. Nice work @pfefferle!

@pfefferle pfefferle requested a review from obenland May 8, 2025 15:18
@pfefferle pfefferle requested a review from obenland May 8, 2025 16:07
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pfefferle pfefferle merged commit 68a9bab into trunk May 9, 2025
11 checks passed
@pfefferle pfefferle deleted the add/surge-support branch May 9, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Health Check [Feature] WP Admin [Focus] Compatibility Ensuring the plugin plays well with other plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments