Skip to content

feat(security): disallow creation of admin user #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rebeccahum merged 2 commits into from
Mar 3, 2025
Merged

feat(security): disallow creation of admin user #6157

rebeccahum merged 2 commits into from
Mar 3, 2025

Conversation

@sjinks
Copy link
Member

@sjinks sjinks commented Mar 2, 2025

Description

This PR disables the creation of the admin user, see BB8-12340.

Changelog Description

Changed

  • Creating the admin user on single site WordPress installation is impossible.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

See BB8-12340 and the unit tests.

@sjinks sjinks self-assigned this Mar 2, 2025
@sjinks sjinks requested a review from a team as a code owner March 2, 2025 18:03
@codecov
Copy link

codecov bot commented Mar 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.43%. Comparing base (50d93d8) to head (39ac1de).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
security.php 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #6157      +/-   ##
=============================================
+ Coverage      30.41%   30.43%   +0.02%     
  Complexity      4830     4830              
=============================================
  Files            290      290              
  Lines          21327    21321       -6     
=============================================
+ Hits            6486     6489       +3     
+ Misses         14841    14832       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rebeccahum
rebeccahum reviewed Mar 3, 2025
View reviewed changes
@rebeccahum rebeccahum merged commit 5c74cf9 into develop Mar 3, 2025
34 checks passed
@rebeccahum rebeccahum deleted the BB8-12340 branch March 3, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebeccahum rebeccahum rebeccahum approved these changes

Assignees

@sjinks sjinks

Labels

[Component] Security ChangelogTagID: 801 [Status] Deployed to production [Type] Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjinks @rebeccahum