-
Notifications
You must be signed in to change notification settings - Fork 54
Update tooltips in the new Previews tab #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tooltips in the new Previews tab #993
Conversation
|
Nice change. Thanks @ndiego! |
|
Thanks for the PR, Nick! I like the tooltip on the values in the Updated column
We may want to display the tooltip at least in cases when there's not enough space for the whole URL to display: At the moment we are also displaying permanent tooltips on sites in the Sync tab. |
It would make sense to bring those back and display the URL, and this is one of the reasons. Maybe we should make the tooltip consistent with other tooltips and change it to say "Open https://.."? |
Oh, great point. I didn't think of that.
I like this as well! I can go ahead and make this change. Sound good? |
|
@ndiego sounds great! |
|
Tooltips have been updated. Let me know if any additional changes need to be made @wojtekn. Thanks! |
|
@ndiego looks great. Tooltips are consistent now. 🥳 |
fredrikekelund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to try and trigger CI

Proposed Changes
This PR contains a few minute updates to the tooltips used on the new Previews tab.
Testing Instructions
Pre-merge Checklist