Skip to content

Conversation

@ndiego
Copy link
Contributor

@ndiego ndiego commented Feb 28, 2025

Proposed Changes

This PR contains a few minute updates to the tooltips used on the new Previews tab.

  • Remove the tooltip for the site URL. It provides no new information beyond the link that's already visible.
  • Add a date/time tooltip for the Updated value. This provides users with the exact date/time their preview was last updated.

Testing Instructions

Preview URL - Before Preview URL - After
image image
Updated - Before Updated - After
image image

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@matt-west
Copy link
Contributor

Nice change. Thanks @ndiego!

@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Mar 3, 2025

Thanks for the PR, Nick! I like the tooltip on the values in the Updated column

Remove the tooltip for the site URL. It provides no new information beyond the link that's already visible.

We may want to display the tooltip at least in cases when there's not enough space for the whole URL to display:

Markup on 2025-03-03 at 09:41:19

At the moment we are also displaying permanent tooltips on sites in the Sync tab.

@wojtekn
Copy link
Contributor

wojtekn commented Mar 3, 2025

We may want to display the tooltip at least in cases when there's not enough space for the whole URL to display:

It would make sense to bring those back and display the URL, and this is one of the reasons. Maybe we should make the tooltip consistent with other tooltips and change it to say "Open https://.."?

@ndiego
Copy link
Contributor Author

ndiego commented Mar 3, 2025

We may want to display the tooltip at least in cases when there's not enough space for the whole URL to display:

Oh, great point. I didn't think of that.

It would make sense to bring those back and display the URL, and this is one of the reasons. Maybe we should make the tooltip consistent with other tooltips and change it to say "Open https://.."?

I like this as well! I can go ahead and make this change. Sound good?

@wojtekn
Copy link
Contributor

wojtekn commented Mar 4, 2025

@ndiego sounds great!

@ndiego ndiego self-assigned this Mar 4, 2025
@ndiego
Copy link
Contributor Author

ndiego commented Mar 4, 2025

Tooltips have been updated. Let me know if any additional changes need to be made @wojtekn. Thanks!

@wojtekn
Copy link
Contributor

wojtekn commented Mar 5, 2025

@ndiego looks great. Tooltips are consistent now. 🥳

@fredrikekelund fredrikekelund requested review from a team and removed request for sejas March 5, 2025 08:22
Copy link
Contributor

@fredrikekelund fredrikekelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to try and trigger CI

@wojtekn wojtekn merged commit 04dd545 into Automattic:trunk Mar 6, 2025
9 checks passed
wojtekn added a commit that referenced this pull request Mar 6, 2025
wojtekn added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants