Improve site name suggestions to ensure both name and path uniqueness #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcotrim
force-pushed
the
fix/new_default_site_folder_name
branch
from
f79c97f to
f51ed5f
Compare
ivan-ottinger
approved these changes
Feb 24, 2025
Contributor
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
Nice clean-up and fix! 👌🏼🙂
- the proposed changes look good
- I could not reproduce the issue we are fixing here anymore
- if all predefined name/path options are exhausted, the default one with a number incremented is suggested:
I did not observe any regressions.
wojtekn
reviewed
Feb 25, 2025
| if ( ! usedSiteNames.includes( defaultName ) ) { | ||
| const isPathUnique = ( name: string ): boolean => { | ||
| const sanitizedPath = sanitizeFolderName( name ); | ||
| return ! usedSites.some( ( site ) => site.path.toLowerCase().endsWith( '/' + sanitizedPath ) ); |
Contributor
Author
There was a problem hiding this comment.
It doesn't, thanks for catching that.
I added a follow-up PR: #976
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Expected results: Site name is suggested without conflicting name or path
Expected results: Site name is suggested without conflicting name or path
Expected results: Site name is suggested, using the default name plus an incremental value, without conflicting name or path
Pre-merge Checklist