Skip to content

Keep custom path open if user selected one #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wojtekn merged 3 commits into from
Jan 9, 2025
Merged

Keep custom path open if user selected one #787

wojtekn merged 3 commits into from
Jan 9, 2025

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jan 8, 2025

Related issues

Proposed Changes

  • I propose to change how a new site dialog form opens the directory dialog, to use the previously selected path if the user selected it already.

Testing Instructions

  1. Start Studio
  2. Click 'Add site'
  3. In the form, open 'Advanced settings'
  4. Select a directory different from the default path, existing or a new one
  5. Open the directory picker again
  6. Confirm that the opened directory is the local path you created/selected previously

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested review from a team and bgrgicak January 8, 2025 11:57
@wojtekn wojtekn self-assigned this Jan 8, 2025
bgrgicak
bgrgicak approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement 🚀

@bgrgicak
Copy link
Contributor

bgrgicak commented Jan 9, 2025

@wojtekn I pushed a linter fix, hope that you don't mind it f7a1e81

fredrikekelund
fredrikekelund approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@fredrikekelund fredrikekelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wojtekn
Copy link
Contributor Author

wojtekn commented Jan 9, 2025

Thanks for pushing the lint fix @bgrgicak, and thank you and @fredrikekelund for the review. 🥳

@wojtekn wojtekn merged commit a0aacb7 into trunk Jan 9, 2025
6 checks passed
@wojtekn wojtekn deleted the fix/opening-path-dialog branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredrikekelund fredrikekelund fredrikekelund approved these changes

@bgrgicak bgrgicak bgrgicak approved these changes

Assignees

@wojtekn wojtekn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local path picker always opens the default Studio path instead of the current path

4 participants

@wojtekn @bgrgicak @fredrikekelund