Unify Import labels and mention another supported formats #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-ottinger
approved these changes
Jan 8, 2025
Contributor
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
The proposed copy is much more clear now. 👌🏼
I just proposed two slight adjustments we could consider (please see the inline comments).
src/components/site-form.tsx
Outdated
| { createInterpolateElement( | ||
| __( 'Jetpack and WordPress backups supported. <button>Learn more</button>' ), | ||
| __( | ||
| 'Import a Jetpack backup or another full-site backup format. <button>Learn more</button>' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Import a Jetpack backup or another full-site backup format. <button>Learn more</button>' | |
| 'Import a Jetpack backup or a full-site backup in another format. <button>Learn more</button>' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Import a Jetpack backup or another full-site backup format. <button>Learn more</button>' | |
| 'Import a Jetpack backup or a full-site backup from another tool or service. <button>Learn more</button>' |
Contributor
Author
There was a problem hiding this comment.
Thanks for your proposals. I updated the text and it looks easier to read now. I chose the shorter version as that way, it still fits into one line in most window sizes.
| { createInterpolateElement( | ||
| __( 'Import a Jetpack backup or a .sql database file. <button>Learn more</button>' ), | ||
| __( | ||
| 'Import a Jetpack backup, another full-site backup, or a .sql database file. <button>Learn more</button>' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Import a Jetpack backup, another full-site backup, or a .sql database file. <button>Learn more</button>' | |
| 'Import a Jetpack backup, a full-site backup in another format, or a .sql database file. <button>Learn more</button>' |
Contributor
There was a problem hiding this comment.
Alternatively, we can also do something like:
Suggested change
| 'Import a Jetpack backup, another full-site backup, or a .sql database file. <button>Learn more</button>' | |
| 'Import a Jetpack backup, a full-site backup from another tool or service, or a .sql database file.. <button>Learn more</button>' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
The import field label currently reads
Jetpack and WordPress backups supportedand seems confusing.I propose to unify the wording used in labels in the 'Add site' form and 'Import / Export' tabs and mention that other formats than Jetback backup are supported.
Testing Instructions
Pre-merge Checklist