Update default PHP version to 8.2 #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejas
approved these changes
Jan 3, 2025
Member
There was a problem hiding this comment.
I confirm the new created sites use the PHP 8.2
Existing sites use the former PHP version, in my case 8.0.
Code changes look clean. We are still using 8.0 in some tests but that seems valid and tests pass correctly.
The new site with PHP 8.2 works as expected and feels faster.
ivan-ottinger
approved these changes
Jan 3, 2025
Contributor
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
The proposed changes look good and a new site created is using PHP version 8.2 by default now.
I haven't observed any issues. The site and their WP Admin is loading correctly, similarly as Antonio observed.
Contributor
Author
|
Thanks for review @sejas and @ivan-ottinger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist