Make drag triggers consistent across the app #75
Conversation
src/components/onboarding.tsx
Outdated
| <div className="h-[569px] flex flex-col justify-center items-start flex-[1_0_0%] gap-8"> | ||
| <div className="w-1/2 bg-white p-[50px] flex flex-col"> | ||
| <div className="h-[569px] flex flex-col justify-center items-start flex-[1_0_0%] gap-8 app-no-drag-region"> | ||
| <div className="flex flex-col items-start self-stretch gap-6"> |
There was a problem hiding this comment.
I noted on the Onboarding screen that there is some non-draggable whitespace above and below the Add Site form. It seems that if the app-no-drag-region class were moved one more element further down, the areas in purple would be draggable as well, still leaving the form itself interactable. I wasn't sure if leaving this space non-draggable was intentional, however, so disregard if so.
<div className="flex flex-col items-start self-stretch gap-6 app-no-drag-region">
Example
draggable.mov
There was a problem hiding this comment.
That's a good thought, I've gone ahead to implement your suggestion in f8a790d.
I had been a bit conservative with the amount of "draggable space" I was introducing, but agree that for the onboarding screen, it would feel a bit odd for all of that white space to not be draggable while the blue sidebar is completely draggable.
derekblank
left a comment
derekblank
left a comment
There was a problem hiding this comment.
I observed the draggable areas mentioned in the PR description have been improved. 👍 Just left a comment for potentially increasing the area even further on the Onboarding screen, but it's not at all a blocker. Otherwise, LGTM! 🚀
Related to 6805-gh-Automattic/dotcom-forge, #28, and #29
Proposed Changes
Testing Instructions
Onboarding screen
Main screen
Pre-merge Checklist