Update the label in the left sidebar when we have a single site running #721
Conversation
|
I'm not convinced it's a good change. 🤷 |
There was a problem hiding this comment.
Functionality-wise, it works as expected for me and I can see the text changing based on whether I have one site or more sites running. One advantage that I spotted while testing this in other languages is that it makes the text shorter and that button generally looks better (for example, in Ukrainian) when only one site is running.
However, I can also see that functionality and related wording being meant for bulk managing the sites e.g. bulk stopping them.
I feel like it is more of a design decision rather than code review call. Let's tag @matt-west for an opinion.
That said, I am approving these changes because they work as expected.
|
I like subtle details like this one. I don’t have a strong opinion on this specific change. |
So do I. Thanks for changing this @sejas. The details matter! :) |
|
Thinking forward, if we add the ability to start all sites, it would make sense to return to the original wording so we have consistent 'Start all' and 'Stop all' actions. |
Agreed, we could change it back in the future if necessary. Maybe we don't even need to "start/stop" sites, and they are always up. |
wojtekn
changed the title
Related issues
Proposed Changes
Stop alllink label toStopwhen there is only one site runningTesting Instructions
npm startStopin the left sidebarStop allin the left sidebarPre-merge Checklist