Limit arm translation modal to mac #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejas
commented
Nov 19, 2024
| // Show warning if running an ARM64 translator | ||
| if ( appGlobals.arm64Translation && ! localStorage.getItem( 'dontShowARM64Warning' ) ) { | ||
| if ( | ||
| appGlobals.platform === 'darwin' && |
Member
Author
There was a problem hiding this comment.
I considered limiting it to appGlobals.platform !== 'win32', but I decided to exclude Linux as well.
wojtekn
approved these changes
Nov 19, 2024
Contributor
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
I don't have a machine to test it, but the code change looks correct. Nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm startand observe there is no alertPre-merge Checklist