Skip to content

Remove regenerate media step after import #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sejas merged 2 commits into from
Oct 31, 2024
Merged

Remove regenerate media step after import #639

sejas merged 2 commits into from
Oct 31, 2024

Conversation

@sejas
Copy link
Member

@sejas sejas commented Oct 31, 2024

Proposed Changes

  • Let's not regenerate media thumbnails as part of the import flow. Users can ask the assistant to run it if they need to.
  • We'll document it in the FAQs

Testing Instructions

  • Download a .wpress or Jetpack backup
  • Run npm start
  • Create a site and select your backup
  • Observe the import succeeds and it doesn't display the "regenerate" media step.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas requested a review from a team October 31, 2024 01:39
@sejas sejas self-assigned this Oct 31, 2024
@sejas sejas force-pushed the remove/regenerate-media-after-import branch from d30816a to 212e4af Compare October 31, 2024 01:48
@katinthehatsite
Copy link
Contributor

katinthehatsite commented Oct 31, 2024 •
edited
Loading

The code changes look good to me and the import succeeded 👍

Observe the import succeeds and it doesn't display the "regenerate" media step.

Where should I be able to observe this?

Actually, ignore my question. I was able to observe it in the loading state

@sejas sejas merged commit 830ddf0 into trunk Oct 31, 2024
10 checks passed
@sejas sejas deleted the remove/regenerate-media-after-import branch October 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtekn wojtekn wojtekn approved these changes

@katinthehatsite katinthehatsite katinthehatsite approved these changes

Assignees

@sejas sejas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sejas @katinthehatsite @wojtekn