Skip to content

Fix overflow issue for extremely long site name #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derekblank merged 2 commits into from
Apr 29, 2024
Merged

Fix overflow issue for extremely long site name #60

derekblank merged 2 commits into from
Apr 29, 2024

Conversation

@derekblank
Copy link
Contributor

@derekblank derekblank commented Apr 29, 2024

Related to:

Proposed Changes

Site titles are already displayed as a single line using line-clamp-1.

This change uses line-clamp-1 and break-all together to prevent text overflow for long unbroken site strings.

extremely-long-site-name.mov

Testing Instructions

  1. Create a site using a very long title (example below)
  2. Modify the horizontal dimensions of the Studio app window
  3. Observe that the site title does not cause the window to overflow (example)
MyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsiteMyWordPressWebsite

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@derekblank derekblank added the bug label Apr 29, 2024
@derekblank derekblank requested a review from a team April 29, 2024 12:00
@derekblank derekblank self-assigned this Apr 29, 2024
@derekblank derekblank linked an issue Apr 29, 2024 that may be closed by this pull request
Extremely long site name causes overflow #59
Closed
sejas
sejas approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great 👌

Screenshot 2024-04-29 at 17 47 41

@derekblank derekblank merged commit 601f200 into trunk Apr 29, 2024
@derekblank derekblank deleted the fix/extremely-long-site-name branch April 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sejas sejas sejas approved these changes

Assignees

@derekblank derekblank

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extremely long site name causes overflow

3 participants

@derekblank @sejas